21134 Added continuation in types for restoration + updated Iran and Turkey #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severinbeauvais
requested review from
eve-git,
shaangill025,
stevenc987,
mengdong19,
ozamani9gh,
rarmitag,
flutistar and
EPortman
as code owners
severinbeauvais
commented
Jun 5, 2024
src/list-data/intl-jurisdictions.ts
Outdated
There was a problem hiding this comment.
These are fixes for bcgov/entity#21568.
- updated description for Iran - updated description for Turkey - added CBEN to business search legal types - added C, CBEN, CCC, and CUL to list of restorable businesses - lint fixes
severinbeauvais
commented
Jun 5, 2024
| EntityTypes.PA, | ||
| EntityTypes.FI, | ||
| EntityTypes.PAR | ||
| ] |
There was a problem hiding this comment.
This was only used in one place so I moved it to lines 41-60.
severinbeauvais
commented
Jun 5, 2024
| EntityTypes.CBEN, | ||
| EntityTypes.CCC, | ||
| EntityTypes.CUL | ||
| ], |
There was a problem hiding this comment.
I'm pretty sure only the REH and CHG arrays are used from here, so those are the only ones I updated.
|
I also added C/CBEN/CCC/CUL to various feature flags: Supported Restoration Entities
Supported Name Change Entities
Supported Amalgamation Entities
|
1 task
|
Temporary Url for review: https://namerequest-dev--pr-768-hau52psz.web.app |
Testing a restoration NR with a C companyIn Dev: In preview site: |
Testing a name-change NR with a C company:In Dev: In preview site: |
rarmitag
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).